Repository navigation
Mark models with non-standard Modelica as invalid - #427
Merged
Merged
Conversation
Some libraries were tested with --allowNonStandardModelica and others were not. Thus the overviews counted some non-standard models as working, and did not show how far the others would get. Testing: - test.py adds --warnNonStandardModelica to the default commands if omc accepts it, and the configurations no longer set --allowNonStandardModelica. - testmodel.py finds the "[Non-standard Modelica: ...]" tag in the messages of omc and writes the options to .stat.json. - Each branch table gets the column invalid (sqlite user_version 6). Library reports put a red cross before the name of an invalid model and give the number of invalid models. Overviews: - The newest run of master on each library says which models are invalid; --invalid-branch selects another branch, for the libraries that master does not test. - The counts and times leave out the invalid models. Buttons at the top show them included, or only them. - The "Now working in ..." tooltips are removed, and one query reads the rows of a library and branch. - New style sheet. Merge this only after a nightly omc has --warnNonStandardModelica. Fixes #426. Assisted-by: Claude Opus 5.5
The overview no longer puts each count in <a>, and </table> is now on the next line. Thus the grep in the workflow did not find the row, and all four jobs failed, although both models simulated and verified. Assisted-by: Claude Opus 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some libraries were tested with --allowNonStandardModelica and others were not. Thus the overviews counted some non-standard models as working, and did not show how far the others would get.
Testing:
Library reports put a red cross before the name of an invalid model and give the number of invalid models.
Overviews:
Merge this only after a nightly omc has --warnNonStandardModelica.
Fixes #426.
Assisted-by: Claude Opus 5.5